Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OPTIONS request in the MVC test framework #205

Closed
wants to merge 1 commit into from

Conversation

acogoluegnes
Copy link
Contributor

There is currently no way to handle OPTIONS request in the MVC test framework, as they always handled by the DispatcherServlet.

I added the options static method in the MockMvcRequestBuilder and add added the dispatchOptions flag to the DefaultMockMvcBuilder. The flag defaults to false, as in the DispatcherServlet.

Issue: SPR-10093

@ghost ghost assigned rstoyanchev Dec 14, 2012
@rstoyanchev
Copy link
Contributor

Thanks for the pull request! Have you signed the CLA before? It should be very quick. See the wiki page.

@acogoluegnes
Copy link
Contributor Author

Yes, I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

rstoyanchev added a commit that referenced this pull request Jan 8, 2013
* tmp:
  Add support for HTTP OPTIONS in Spring MVC Test
@rstoyanchev
Copy link
Contributor

This has now been merged, thanks! Note that currently development is still on the 3.2.x branch with periodic merges into master. So the commit is added to 3.2.x.

@rstoyanchev rstoyanchev closed this Jan 8, 2013
cbeams added a commit that referenced this pull request Jan 11, 2013
 - Replace space intendation with tabs
 - Remove leading tabs on otherwise empty lines
 - Remove illegal {@link ...} syntax in Javadoc @see reference

Issue: SPR-10093
cbeams added a commit that referenced this pull request Jan 11, 2013
* SPR-10093:
  Polish changes from pull request #205
@cbeams
Copy link
Contributor

cbeams commented Jan 11, 2013

@acogoluegnes, @rstoyanchev, you may want to take a look at 7413779, in which I polish up the commit merged earlier here. And thanks Arnaud for the contribution! Good to see you around.

@rstoyanchev
Copy link
Contributor

Thanks Chris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants